Skip to content

fix: Construction of OIDC endpoint when rootPath has a trailing slash #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix: Construction of OIDC endpoint when rootPath has a trailing slash #547

merged 4 commits into from
Nov 25, 2024

Conversation

sbernauer
Copy link
Member

Description

Part of stackabletech/operator-rs#910

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

labrenbe
labrenbe reviewed Nov 25, 2024
View reviewed changes
@sbernauer sbernauer mentioned this pull request Nov 25, 2024
Merged
5 tasks
labrenbe
labrenbe previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer
Copy link
Member Author

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/13/

@sbernauer
Copy link
Member Author

The test takes >2h, but the relevant OIDC tests already passed

@sbernauer sbernauer added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit f3eb0af Nov 25, 2024
16 of 17 checks passed
@sbernauer sbernauer deleted the fix/oidc-endpoint branch November 25, 2024 13:02
@siegfriedweber siegfriedweber mentioned this pull request Nov 26, 2024
Merged
@lfrancke
Copy link
Member

lfrancke commented Dec 4, 2024

Did this make it into 24.11?

@sbernauer
Copy link
Member Author

Nope, but it will be part of 24.11.1. Not sure what label we should use here ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labrenbe labrenbe labrenbe approved these changes

Assignees
No one assigned
Labels
release/24.11.1 type/bug
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @lfrancke @labrenbe